Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh import filters not displaying correctly on KDE #2731 (backport #2732) #2736

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix mesh import filters not displaying correctly on KDE #2731 (backport #2732) #2736

merged 1 commit into from
Jan 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 27, 2025

🦟 Bug fix

Fixes #2731

Summary

Adds labels for mesh import type filter to compensate for a bug (related?) in KDE, but is probably good practice anyway.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This is an automatic backport of pull request #2732 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from mjcarroll as a code owner January 27, 2025 08:02
@mergify mergify bot mentioned this pull request Jan 27, 2025
Merged
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 27, 2025
@ahcorde ahcorde enabled auto-merge (squash) January 27, 2025 08:31
@ahcorde ahcorde merged commit bc12c77 into gz-sim8 Jan 27, 2025
9 of 10 checks passed
@ahcorde ahcorde deleted the mergify/bp/gz-sim8/pr-2732 branch January 27, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @joshnewans